Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ignored invariant boolean warning #47

Merged
merged 3 commits into from
May 13, 2022
Merged

refactor: ignored invariant boolean warning #47

merged 3 commits into from
May 13, 2022

Conversation

alestiago
Copy link
Collaborator

@alestiago alestiago commented Mar 25, 2022 •
edited
Loading

Description

Analyser showing invariant_boolean warning.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@alestiago alestiago marked this pull request as draft March 25, 2022 09:05
@alestiago alestiago marked this pull request as ready for review May 13, 2022 12:32
@alestiago alestiago mentioned this pull request May 13, 2022
Merged
7 tasks
@alestiago alestiago changed the title refactor: removed invariant boolean refactor: ignored invariant boolean warning May 13, 2022
@spydon spydon merged commit c032f9c into flame-engine:main May 13, 2022
@alestiago alestiago deleted the refactor/removed-invariant-boolean branch May 13, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alestiago @spydon